PATCH: connect giro3d model loading to viewer new API (#178)

* connect giro3d model loading to viewer new API * update girod 3D plugin version * update girod3d plugin version
bimdata · Jun 4, 2024 · b555705 · b555705
1 parent 9b90581
commit b555705
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 10 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/plugins/giro3d/dist/giro3d.plugin.js b/src/plugins/giro3d/dist/giro3d.plugin.js
diff --git a/src/plugins/giro3d/package-lock.json b/src/plugins/giro3d/package-lock.json
diff --git a/src/plugins/giro3d/package.json b/src/plugins/giro3d/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@bimdata/giro3d-viewer-plugin",
   "type": "module",
-  "version": "2.0.1",
+  "version": "2.0.5",
   "description": "giro3d BIMData Viewer Plugin",
   "scripts": {
     "build": "vite build && terser -c -m -o dist/giro3d.plugin.js --module dist/giro3d.plugin.js",

diff --git a/src/plugins/giro3d/src/Giro3d.vue b/src/plugins/giro3d/src/Giro3d.vue
@@ -1,7 +1,7 @@
 <template>
   <div class="bimdata-giro3d">
     <NoModelWindowPlaceHolder v-if="loadedModelIds.length === 0 && !loading" />
-    <ModelsLoader :types="['POINT_CLOUD']" @load-models="loadModels" @unload-models="unloadModels" preview />
+    <ModelsLoader preview />
     <div :id="giro3dDivId" class="bimdata-giro3d__viewer"></div>
   </div>
 </template>
@@ -32,6 +32,7 @@ export default {
   },
   unmounted() {
     this.$viewer.globalContext.hub.off(this.localContextResizeSubscription);
+    this.localContextSubscriptions?.forEach(subscription => this.$viewer.localContext.hub.off(subscription));
   },
   async mounted() {
     const viewerDiv = document.getElementById(this.giro3dDivId);
@@ -59,6 +60,11 @@ export default {
 
     this.instance = instance;
     this.controls = controls;
+
+    this.localContextSubscriptions = [
+      this.$viewer.localContext.hub.on("models-loaded", ({ models }) => this.loadModels(models), { getLastEvent: true }),
+      this.$viewer.localContext.hub.on("models-unloaded", ({ models }) => this.unloadModels(models), { getLastEvent: true })
+    ]
   },
   methods: {
     onResize({ width, height }) {

diff --git a/src/plugins/giro3d/src/giro3d.plugin.js b/src/plugins/giro3d/src/giro3d.plugin.js
@@ -7,6 +7,7 @@ export default {
     name: 'giro3d',
     label: 'Giro3dPlugin.window_label',
     plugins: ['fullscreen'],
+    modelTypes: ["POINT_CLOUD"],
   },
   i18n: {
     en: {