REFACTOR: make ROQ likelihood call Interferometer.get_detector_response #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColmTalbot
changed the title
ColmTalbot
changed the title
SMorisaki
reviewed
Nov 7, 2024
| signal = {} | ||
| for mode in waveform_polarizations.keys(): | ||
| det_response = self.antenna_response( | ||
| parameters['ra'], | ||
| parameters['dec'], | ||
| parameters['geocent_time'], | ||
| antenna_time, |
There was a problem hiding this comment.
Similarly, the input time to self.time_delay_from_geocenter should be replaced by antenna_time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #847, this PR makes the ROQ likelihood call the standard detector response code. This required some refactoring of the roq source model. After this change, it would be possible to entirely remove that source model and pass everything through the
frequency_sequencyfunctions directly.This might need some more refactoring to simplify the logic in the source module.
Needs #847