GH #86: Add LANE to withTrafficCyclewayTags

core/src/main/java/com/graphhopper/routing/util/BikeCommonFlagEncoder.java

@@ -198,6 +198,7 @@ protected BikeCommonFlagEncoder(String name, int speedBits, double speedFactor,
         cyclewayMap.put(SHARE_BUSWAY, SLIGHT_PREFER.getValue());
         cyclewayMap.put(LANE, PREFER.getValue());
         cyclewayMap.put(TRACK, VERY_NICE.getValue());
+        withTrafficCyclewayTags.add(LANE);
         withTrafficCyclewayTags.add(SHARED_LANE);
         withTrafficCyclewayTags.add(SHOULDER);
 

core/src/test/java/com/graphhopper/routing/util/CayugaAlemanyTest.java

@@ -0,0 +1,58 @@
+package com.graphhopper.routing.util;
+
+
+import com.graphhopper.reader.ReaderRelation;
+import com.graphhopper.reader.ReaderWay;
+import com.graphhopper.routing.ev.DecimalEncodedValue;
+import com.graphhopper.storage.IntsRef;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+
+public class CayugaAlemanyTest {
+    protected BikeFlagEncoder encoder;
+    protected TagParserManager encodingManager;
+    protected DecimalEncodedValue penaltyEnc;
+
+    @BeforeEach
+    public void setUp() {
+        encodingManager = TagParserManager.create(encoder = new BikeFlagEncoder("bike"));
+        penaltyEnc = encodingManager.getDecimalEncodedValue(EncodingManager.getKey(encoder, "penalty"));
+    }
+
+    @Test
+    public void test_cayuga() {
+        ReaderWay cayuga = new ReaderWay(3);
+        cayuga.setTag("highway", "residential");
+        cayuga.setTag("maxspeed", "25 mph");
+        cayuga.setTag("motor_vehicle", "destination");
+
+        IntsRef relFlags = encodingManager.handleRelationTags(new ReaderRelation(0),
+                encodingManager.createRelationFlags());
+        IntsRef edgeFlags = encodingManager.handleWayTags(cayuga, relFlags);
+
+        // Penalty should be SLIGHT_PREFER because of highway=residential.
+        assertEquals(PenaltyCode.SLIGHT_PREFER.getValue(),
+                penaltyEnc.getDecimal(false, edgeFlags));
+    }
+
+    @Test
+    public void test_alemany() {
+        ReaderWay alemany = new ReaderWay(3);
+        alemany.setTag("cycleway:right", "lane");
+        alemany.setTag("highway", "primary");
+        alemany.setTag("maxspeed", "35 mph");
+        alemany.setTag("oneway", "yes");
+
+        IntsRef relFlags = encodingManager.handleRelationTags(new ReaderRelation(0),
+                encodingManager.createRelationFlags());
+        IntsRef edgeFlags = encodingManager.handleWayTags(alemany, relFlags);
+
+        // The penalty should be elevated because cycleway=lane is cycling
+        // infrastructure that is exposed to car traffic.
+        assertEquals(PenaltyCode.BAD.getValue(),
+                penaltyEnc.getDecimal(false, edgeFlags));
+    }
+}