fix: Generic assay plugin bugs #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now also closes #1984. What happens if we try to create links in an ontology or list column? Should we check for that? |
mikkonie
requested changes
Sep 2, 2024
I would say these cases should be checked, as long as there's a somewhat-realistic chance someone woult attempt to create links to such columns. I'm not sure if it needs to go in this PR though or if it should be considered an additional feature. You make the call :) |
sellth
changed the title
|
The project might end up in a state which the user cannot recover from without admin help, but it will probably be an edge case. I would prioritise getting these fixes out. |
mikkonie
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1982