Add "create" tag for sheet versions & Add tests for templatetags #1728
Conversation
Another Issue: #1723TODO:
btw: I found an interesting approach to avoid imports of IrodsRequest and ISATab - just mocking them. I hope it works fine, if not - let me know and I will reimplement them. |
gromdimon
changed the title
There was a problem hiding this comment.
Looks good and works just as expected, good work. I have some requests for changes, mainly related to style issues.
These should preferably have been two separate PRs as they are not related in any other way than belonging in the same app, but it's not a big deal since it's not a huge PR.
gromdimon
force-pushed
the
1296-add-create-tag-for-sheet-versions
branch
from
1ecf6a1
to
666d17b
Compare
| # Assert that study path exists in the returned string | ||
| self.assertIn(self.irods_backend.get_sub_path(self.study), ret) | ||
| # Assert that assay path exists in the returned string | ||
| path0, path1 = self.irods_backend.get_sub_path(self.assay).split('/') |
There was a problem hiding this comment.
I'm not sure if I understand what happens here. You split the same path into two parts and then assert both of them are found in the return data. Why not just assert the inclusion of the full path?
There was a problem hiding this comment.
The reason for that is response. It is html, which is formed with tags:
<ul><li>sample_data<ul><li>study_dff42df4-362a-460c-86cf-749897eb6190<ul><li>assay_f9fb2c7d-9541-4a44-a8a3-0bbaebfdb7ce</li></ul></li></ul></li></ul>
So I've splited path and asserted it separately, as it was the simplest solution :)
Issue #1296
TODO: