Skip to content

Commit

Permalink
rename update_cache_rows() (#1933)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikkonie committed Aug 8, 2024
1 parent daeeb8d commit 3b7e6da
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion samplesheets/assayapps/cytof/plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,4 +165,4 @@ def update_cache(self, name=None, project=None, user=None):
:param project: Project object to limit update to (optional)
:param user: User object to denote user triggering the update (optional)
"""
self._update_cache_rows(APP_NAME, name, project, user)
self.update_cache_rows(APP_NAME, name, project, user)
2 changes: 1 addition & 1 deletion samplesheets/assayapps/dna_sequencing/plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,4 @@ def update_cache(self, name=None, project=None, user=None):
:param project: Project object to limit update to (optional)
:param user: User object to denote user triggering the update (optional)
"""
self._update_cache_rows(APP_NAME, name, project, user)
self.update_cache_rows(APP_NAME, name, project, user)
2 changes: 1 addition & 1 deletion samplesheets/assayapps/generic/plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,4 +209,4 @@ def update_cache(self, name=None, project=None, user=None):
:param project: Project object to limit update to (optional)
:param user: User object to denote user triggering the update (optional)
"""
self._update_cache_rows(APP_NAME, name, project, user)
self.update_cache_rows(APP_NAME, name, project, user)
2 changes: 1 addition & 1 deletion samplesheets/assayapps/microarray/plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,4 +148,4 @@ def update_cache(self, name=None, project=None, user=None):
:param project: Project object to limit update to (optional)
:param user: User object to denote user triggering the update (optional)
"""
self._update_cache_rows(APP_NAME, name, project, user)
self.update_cache_rows(APP_NAME, name, project, user)
2 changes: 1 addition & 1 deletion samplesheets/plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -987,7 +987,7 @@ def update_cache(self, name=None, project=None, user=None):

# Common cache update utilities --------------------------------------

def _update_cache_rows(self, app_name, name=None, project=None, user=None):
def update_cache_rows(self, app_name, name=None, project=None, user=None):
"""
Update cache for row-based iRODS links using get_row_path().
Expand Down
4 changes: 2 additions & 2 deletions samplesheets/tests/test_plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def setUp(self):
def test_update_cache_rows(self):
"""Test update_cache_rows()"""
self.assertIsNone(self.cache_backend.get_cache_item(**self.item_kwargs))
self.plugin._update_cache_rows(ASSAY_PLUGIN_NAME, project=self.project)
self.plugin.update_cache_rows(ASSAY_PLUGIN_NAME, project=self.project)
cache_item = self.cache_backend.get_cache_item(**self.item_kwargs)
self.assertIsNotNone(cache_item)
self.assertTrue(
Expand All @@ -128,6 +128,6 @@ def test_update_invalid_path(self):
m.name = 'invalid/../path'
m.save()
with self.assertRaises(ValueError):
self.plugin._update_cache_rows(
self.plugin.update_cache_rows(
ASSAY_PLUGIN_NAME, project=self.project
)

0 comments on commit 3b7e6da

Please sign in to comment.