Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix restoreHistory title replacment #2841

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

MichaelWest22
Copy link
Contributor

@MichaelWest22 MichaelWest22 commented Aug 22, 2024

Description

It seems that when the handleTitle() function was introduced the restoreHistory() title setting code was accidently changed to use fragment.title instead of the proper cached.title. Firefox does not keep track of title during history switching so title doesn't change now because there is no title inside the fragment data. Chrome works fine as it tracks the page title itself.

Corresponding issue:
#2833

Testing

I've tested this trival change in firefox and chrome to make sure it works fine and updates the title as expected

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added bug Something isn't working ready for review Issues that are ready to be considered for merging labels Aug 22, 2024
@1cg 1cg merged commit bc4468d into bigskysoftware:dev Aug 29, 2024
1 check failed
@1cg
Copy link
Contributor

1cg commented Aug 29, 2024

Great fix, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review Issues that are ready to be considered for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants