Shift monterey_county_district_attorney config stuff to inside state #89 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@naumansharifwork , can you give this a look please? Not sure I can request you as a reviewer. This was ... not exactly major surgery tho. |
newsroomdev
approved these changes
Aug 19, 2024
|
@stucka changes looks good |
naumansharifwork
pushed a commit
to naumansharifwork/clean-scraper
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
configdirectory should be inside the state-level directoriesSummary of Changes
configdirectory out of /clean into /clean/caRelated Issues
This should solve issue #89
How to Review
Command-line testing worked for me, something like
python -m clean.cli scrape-meta ca_monterey_county_district_attorney -l debugNotes