Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Adam - 2401] Refactoring Error Messages #2403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Adam - 2401] Refactoring Error Messages #2403

wants to merge 1 commit into from

Conversation

joonkang-git
Copy link

Refactored exception handling to be more consistent, resolving issue #2401.
IllegalArgumentException for issues arising from input-related issues.
IllegalStateException for issues arising from internal logic issues.
UnsupportedOperationException for cases when a called method is not meant for use.

heuermh
heuermh approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@heuermh heuermh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for your contribution!

@heuermh heuermh added this to the 1.0.2 milestone Aug 13, 2024
@heuermh
Copy link
Member

heuermh commented Aug 13, 2024

Fixes #2401

@heuermh
Copy link
Member

heuermh commented Aug 13, 2024

Looks like one or more unit tests also need updating

- CIGAR/MD tag mismatch should cause errors *** FAILED ***
  Expected exception scala.MatchError to be thrown, but java.lang.UnsupportedOperationException
was thrown (MdTagSuite.scala:628)
  org.scalatest.exceptions.TestFailedException: ...

@joonkang-git
Copy link
Author

Hi, will work through editing the unit test thank you for your response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heuermh heuermh heuermh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@joonkang-git @heuermh