fix: add precompile error for renderString (#322)

bigcommerce · Aug 6, 2024 · 06d3580 · 06d3580
1 parent 615f7d4
commit 06d3580
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/index.js b/index.js
@@ -4,7 +4,7 @@ const HandlebarsV4 = require('@bigcommerce/handlebars-v4');
 const helpers = require('./helpers');
 
 const AppError = require('./lib/appError');
-const { CompileError, FormatError, RenderError, DecoratorError, TemplateNotFoundError, ValidationError } = require('./lib/errors');
+const { CompileError, FormatError, RenderError, DecoratorError, TemplateNotFoundError, ValidationError, PrecompileError } = require('./lib/errors');
 
 const handlebarsOptions = {
     preventIndent: true
@@ -23,6 +23,7 @@ class HandlebarsRenderer {
             DecoratorError,
             TemplateNotFoundError,
             ValidationError,
+            PrecompileError,
         };
     }
 
@@ -335,17 +336,21 @@ class HandlebarsRenderer {
      */
     renderString(template, context) {
         return new Promise((resolve, reject) => {
-            let precompiledTemplate;
+            let precompiled, precompiledTemplate;
             context = context || {};
 
             if (typeof template !== 'string') {
                 return reject(new CompileError('Template must be a string'));
             }
 
-            // Compile the template
             try {
                 delete this.handlebars.compile;
-                const precompiled = this.handlebars.precompile(template, handlebarsOptions);
+                precompiled = this.handlebars.precompile(template, handlebarsOptions);
+            } catch (e) {
+                return reject(new PrecompileError(e.message));
+            }
+
+            try {
                 eval(`precompiledTemplate = ${precompiled}`);
                 template = this.handlebars.template(precompiledTemplate);
             } catch(e) {

diff --git a/lib/errors.js b/lib/errors.js
@@ -6,12 +6,14 @@ class RenderError extends AppError {};           // Error rendering template
 class DecoratorError extends AppError {};        // Error applying decorator
 class TemplateNotFoundError extends AppError {}; // Template not registered
 class ValidationError extends Error {};
+class PrecompileError extends Error {};
 
 module.exports = {
     CompileError,
     FormatError,
     RenderError,
     DecoratorError,
     TemplateNotFoundError,
-    ValidationError 
+    ValidationError,
+    PrecompileError
 };
diff --git a/spec/index.js b/spec/index.js
@@ -372,9 +372,9 @@ describe('renderString', () => {
         });
     });
 
-    it('throws RenderError if given malformed template', done => {
+    it('throws PrecompileError if given malformed template', done => {
         renderer.renderString('{{', context).catch(e => {
-            expect(e instanceof HandlebarsRenderer.errors.CompileError).to.be.true();
+            expect(e instanceof HandlebarsRenderer.errors.PrecompileError).to.be.true();
             done();
         });
     });