refactor(core): homepage #1386

jorgemoya · 2024-09-18T21:29:45Z

What/Why?

Uses vibes components to build home page.
- Subscribe is WIP and not hooked up.
- Cart count is not working.
Enabled two locales for testing purposes.

Testing

Locally.

changeset-bot · 2024-09-18T21:29:49Z

⚠️ No Changeset found

Latest commit: f3e8ad6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-09-18T21:29:49Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
catalyst-au	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 24, 2024 5:17pm
catalyst-latest	✅ Ready (Inspect)	Visit Preview		Sep 24, 2024 5:17pm

5 Skipped Deployments

Name	Status	Preview	Updated (UTC)
catalyst	⬜️ Ignored (Inspect)		Sep 24, 2024 5:17pm
catalyst-1millionproducts-store	⬜️ Ignored (Inspect)	Visit Preview	Sep 24, 2024 5:17pm
catalyst-test-store	⬜️ Ignored (Inspect)	Visit Preview	Sep 24, 2024 5:17pm
catalyst-uk	⬜️ Ignored (Inspect)	Visit Preview	Sep 24, 2024 5:17pm
catalyst-unstable	⬜️ Ignored (Inspect)	Visit Preview	Sep 24, 2024 5:17pm

jorgemoya · 2024-09-18T22:10:46Z

core/components/header/_actions/search.ts

+// eslint-disable-next-line @typescript-eslint/require-await
+export const search = async (formData: FormData) => {
+  const searchTerm = z.string().parse(formData.get('searchTerm'));
+
+  if (searchTerm) {
+    redirect(`/search?term=${searchTerm}`);
+  }
+};


Seems like server actions need to be async functions, but there's no async function inside this. Is this the best way to solve this?

Do we need this to be a server action? Could it be a client side router.push?

Pushed an update to just use the client.

github-actions · 2024-09-23T19:18:17Z

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-jalyxo6ya-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category	Score
🟠 Performance	68
🟠 Accessibility	80
🟢 Best practices	96
🟠 SEO	82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category	Score
🟢 Performance	91
🟠 Accessibility	81
🟢 Best practices	96
🟠 SEO	85

jorgemoya requested a review from a team as a code owner September 18, 2024 21:29

jorgemoya changed the title ~~feat(core):~~ refactor(core): add soul components in Homepage Sep 18, 2024

vercel bot deployed to Preview – catalyst-latest September 18, 2024 21:44 View deployment

jorgemoya force-pushed the vibes/soul-homepage branch from e6981aa to 2470313 Compare September 18, 2024 21:44

jorgemoya commented Sep 18, 2024

View reviewed changes

vercel bot deployed to Preview – catalyst-latest September 18, 2024 22:11 View deployment

vercel bot deployed to Preview – catalyst-latest September 18, 2024 22:14 View deployment

jorgemoya force-pushed the vibes/soul-homepage branch from 8a66729 to b20fe7c Compare September 23, 2024 15:43

vercel bot had a problem deploying to Preview – catalyst-latest September 23, 2024 15:44 Failure

vercel bot deployed to Preview – catalyst-latest September 23, 2024 15:51 View deployment

jorgemoya force-pushed the vibes/soul-homepage branch from 2196332 to 7869865 Compare September 23, 2024 16:02

vercel bot deployed to Preview – catalyst-latest September 23, 2024 16:04 View deployment

jorgemoya force-pushed the vibes/soul-homepage branch from 7869865 to 73da89b Compare September 23, 2024 18:18

vercel bot had a problem deploying to Preview – catalyst-latest September 23, 2024 18:20 Failure

jorgemoya changed the title ~~refactor(core): add soul components in Homepage~~ refactor(core): homepage Sep 23, 2024

vercel bot deployed to Preview – catalyst-latest September 23, 2024 18:24 View deployment

vercel bot deployed to Preview – catalyst-latest September 23, 2024 18:28 View deployment

vercel bot deployed to Preview – catalyst-latest September 23, 2024 19:16 View deployment

deini approved these changes Sep 24, 2024

View reviewed changes

jorgemoya added 8 commits September 24, 2024 11:00

chore: setup tailwind config and layout fonts

e624266

feat: add header

2f6a9ad

feat: add footer

03f9696

feat: add slideshow

688954a

chore: add electric styles

2e28186

feat: add featured-products-carousel

f4d75bd

feat: add featured-image

886b019

feat: add featured-products-list

5b7ee80

jorgemoya added 7 commits September 24, 2024 11:00

fix: remove skeleton since new ux does not need it

5bcb220

fix: remove cart prop from header

15f8439

fix: remove cart from not found

4d0fcb8

fix: change lock

7bce1d2

fix: remove empty line

514e8c7

fix: use client action for search form

5fa71ab

fix: imports after rebase

bdee7aa

jorgemoya force-pushed the vibes/soul-homepage branch from e91a41a to bdee7aa Compare September 24, 2024 16:16

vercel bot deployed to Preview – catalyst-latest September 24, 2024 16:18 View deployment

vercel bot deployed to Preview – catalyst-au September 24, 2024 16:18 View deployment

fix: reset pnpm-lock

f3425ef

vercel bot deployed to Preview – catalyst-au September 24, 2024 16:30 View deployment

vercel bot deployed to Preview – catalyst-latest September 24, 2024 16:30 View deployment

fix: tailwind config to include new root path

004f28e

vercel bot deployed to Preview – catalyst-latest September 24, 2024 17:08 View deployment

vercel bot deployed to Preview – catalyst-au September 24, 2024 17:08 View deployment

fix: change order

f3e8ad6

vercel bot deployed to Preview – catalyst-au September 24, 2024 17:16 View deployment

vercel bot deployed to Preview – catalyst-latest September 24, 2024 17:17 View deployment

jorgemoya merged commit 58056f8 into vibes/soul Sep 24, 2024
13 of 16 checks passed

jorgemoya deleted the vibes/soul-homepage branch September 24, 2024 18:07

jorgemoya added a commit that referenced this pull request Sep 24, 2024

refactor(core): homepage (#1386)

597cc7b

jorgemoya added a commit that referenced this pull request Oct 1, 2024

refactor(core): homepage (#1386)

bb79b55

jorgemoya added a commit that referenced this pull request Oct 2, 2024

refactor(core): homepage (#1386)

4f12e11

jorgemoya added a commit that referenced this pull request Oct 3, 2024

refactor(core): homepage (#1386)

f5fdfac

jorgemoya added a commit that referenced this pull request Oct 8, 2024

refactor(core): homepage (#1386)

7965e47

jorgemoya added a commit that referenced this pull request Oct 10, 2024

refactor(core): homepage (#1386)

c327060

jorgemoya added a commit that referenced this pull request Oct 11, 2024

refactor(core): homepage (#1386)

3befa32

jorgemoya added a commit that referenced this pull request Oct 15, 2024

refactor(core): homepage (#1386)

e6ff074

jorgemoya added a commit that referenced this pull request Oct 22, 2024

refactor(core): homepage (#1386)

96f98f7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(core): homepage #1386

refactor(core): homepage #1386

jorgemoya commented Sep 18, 2024 •

edited

Loading

changeset-bot bot commented Sep 18, 2024 •

edited

Loading

vercel bot commented Sep 18, 2024 •

edited

Loading

jorgemoya Sep 18, 2024

deini Sep 23, 2024

jorgemoya Sep 23, 2024

github-actions bot commented Sep 23, 2024

refactor(core): homepage #1386

refactor(core): homepage #1386

Conversation

jorgemoya commented Sep 18, 2024 • edited Loading

What/Why?

Testing

changeset-bot bot commented Sep 18, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Sep 18, 2024 • edited Loading

jorgemoya Sep 18, 2024

Choose a reason for hiding this comment

deini Sep 23, 2024

Choose a reason for hiding this comment

jorgemoya Sep 23, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 23, 2024

⚡️🏠 Lighthouse report

🖥️ Desktop

📱 Mobile

jorgemoya commented Sep 18, 2024 •

edited

Loading

changeset-bot bot commented Sep 18, 2024 •

edited

Loading

vercel bot commented Sep 18, 2024 •

edited

Loading