Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Line at the end of file (feature) #204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

buchtadan
Copy link

This pull request adds a new feature that allows user to configure wether they want a newline at the end of the file or not.

The intension behind this feature is to simplify the display of changes and the reduction of merge conflicts caused by some IDE formatting.
It would fix a lot of issues on one of the projects I'm working on also it seems that there is a need for it. #201

This PR is kinda similar to the PR #148 only on the current stage of this branch.

I would love to see this feature. Keep up the great work.
Let me know what you think and greetings.

@lincrosenbach
Copy link

Thanks @buchtadan. @biesbjerg I would love to see this feature too.

@gabrielmaldi
Copy link

Is there something I can help with to move this PR forward? Thanks!

@gabrielmaldi
Copy link

@buchtadan I see that you released v7.0.2-enhancedFork with your changes. Would it be possible for you to rebase your changes and release a new version targeting @angular/compiler@11 (instead of v10)? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants