This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
BIDSLayout.get_collections / bids.variables #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdalkaraca
reviewed
Dec 13, 2022
| @@ -64,8 +64,57 @@ def get_tr(self, derivatives=False, **entities): | |||
| .format(entities)) | |||
| return all_trs.pop() | |||
|
|
|||
| class BIDSLayoutVariablesMixin: | |||
| def get_collections(self, level, types=None, variables=None, merge=False, | |||
There was a problem hiding this comment.
does get_collections() already work using the current state of BIDSLayout? would be great :-)
There was a problem hiding this comment.
Not quite yet. It's not terribly far though.
adelavega
force-pushed
the
get_collections
branch
from
d4b97c8
to
48edd69
Compare
adelavega
force-pushed
the
get_collections
branch
from
e1b8e88
to
095ad8b
Compare
|
Looks like this is working now! Haven't tested it fully but it runs through on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point, keeping track of blocking issues:
datatypeDatatype entity is missed #11Questions:
get_collections, to clean base class clean, or should we just add toBIDSLayout. It's primarily a convenience function that we could remove entirely