[ENH] events.tsv should be sorted by onset values #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Remi-Gau
commented
Mar 20, 2024
Remi-Gau
commented
- closes Event onset times can be out of order #1691
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1732 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 16 16
Lines 1351 1351
=======================================
Hits 1188 1188
Misses 163 163 ☔ View full report in Codecov by Sentry. |
|
Will propose schema rule. Bug me if I don't do this soon enough for you. |
sappelhoff
approved these changes
Mar 21, 2024
effigies
reviewed
Mar 21, 2024
src/schema/rules/checks/events.yaml
Outdated
Comment on lines
37
to
41
| selectors: | ||
| - suffix == "events" | ||
| - extension == ".tsv" | ||
| checks: | ||
| - sorted(columns.onset) == columns.onset |
There was a problem hiding this comment.
n/a would be the only thing to mess it up if allowed. Otherwise looks good.
There was a problem hiding this comment.
Good point. I think it being a warning should make that an annoyance, not a show-stopper. Will add a comment, though.
effigies
reviewed
Mar 25, 2024
effigies
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.