[SCHEMATOOLS] Implement inheritance for all TSV/JSON files #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
added
schema-code
effigies
force-pushed
the
schemacode/tsv-inheritance
branch
from
c1dba72
to
7d8844e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1671 +/- ##
==========================================
- Coverage 87.97% 87.93% -0.05%
==========================================
Files 16 16
Lines 1356 1351 -5
==========================================
- Hits 1193 1188 -5
Misses 163 163 ☔ View full report in Codecov by Sentry. |
rwblair
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation assumed that, if a file rule only contained TSV or JSON files, then at least one of these was not inheritable. This seems to contradict the inheritance principle, unless the files cease to be "metadata" files, as well as fails to validate actual files in examples, such as
channels.tsvandevents.tsv.If the rule needs to become more complex, the schema will need a way to indicate whether a rule addresses data or metadata files.