REL: v1.9.0

[Remi-Gau]

No description provided.

[Remi-Gau]

not sure why the country was removed here

[Remi-Gau]

and here

[Remi-Gau]

why was this shortened this much?

[Remi-Gau]

Note for the contributor workflow PR: more changes than needed here

[Remi-Gau]

Leaving some comments in the PR that are more related to the contributors update worflow: not important for the release per se.

[Remi-Gau]

@sappelhoff

This section was a bit unclear:

https://github.com/bids-standard/bids-specification/blob/master/Release_Protocol.md#23-update-the-previous-version-urls

• should mention that this about the src/CHNAGES.md
• also either this changes has to be reverted after the release and it is not mentioned in the release protocol or this step was not applied in the previous release

[sappelhoff]

should mention that this about the src/CHANGES.md

You are right @Remi-Gau it should mention that.

also either this changes has to be reverted after the release and it is not mentioned in the release protocol or this step was not applied in the previous release

it is automatically "overwritten" by the GitHub Changelog Generator that we are using -- these steps have always been applied, as can be verified by checking the stable changelog: https://bids-specification.readthedocs.io/en/stable/CHANGES.html

[Remi-Gau]

OK we should mention both points in the protocol then.

[sappelhoff]

cc @sjeung @JuliusWelzel FYI we'll release in around 5 days :-)

[Remi-Gau]

ok. everyone stand back!!! we are merging!!!

[Remi-Gau]

should mention that this about the src/CHANGES.md

You are right @Remi-Gau it should mention that.

also either this changes has to be reverted after the release and it is not mentioned in the release protocol or this step was not applied in the previous release

it is automatically "overwritten" by the GitHub Changelog Generator that we are using -- these steps have always been applied, as can be verified by checking the stable changelog: https://bids-specification.readthedocs.io/en/stable/CHANGES.html

@sappelhoff maybe I missed something in the release protocols but when are the URLs in the changelog reverted to the github version rather than the RTD one?

[effigies]

Next PR merge will trigger the changelog generator.

[sappelhoff]

@sappelhoff maybe I missed something in the release protocols but when are the URLs in the changelog reverted to the github version rather than the RTD one?

this happens automatically (via the GH changelog generator) once the first PR is merged via a "create merge commit" (so not squash and not rebase) method (because that's what triggers the generator), see:

bids-specification/.circleci/config.yml

Line 110 in b0e6744

if (git log -1 --pretty=%s | grep Merge*) && (! git log -1 --pretty=%b | grep REL:) ; then

[Remi-Gau]

@sappelhoff maybe I missed something in the release protocols but when are the URLs in the changelog reverted to the github version rather than the RTD one?

this happens automatically (via the GH changelog generator) once the first PR is merged via a "create merge commit" (so not squash and not rebase) method (because that's what triggers the generator), see:

bids-specification/.circleci/config.yml

Line 110 in b0e6744

if (git log -1 --pretty=%s | grep Merge*) && (! git log -1 --pretty=%b | grep REL:) ; then

ha OK then I messed that up...

[Remi-Gau]

7bff097

The release protocol said commit to master, so committed AND pushed to master (on upstream) #YOLO

Probably worth fixing that in a separate PR.

[sappelhoff]

yes, together with the other items of note to change in the release protocol 👍

[Remi-Gau]

definitely a good thing I did this release then: allowed to clarify a few things