Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCHEMA: Enable structured Level descriptions for TSV columns #1648

Merged
merged 1 commit into from
Nov 7, 2023
Merged

SCHEMA: Enable structured Level descriptions for TSV columns #1648

merged 1 commit into from
Nov 7, 2023

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Nov 2, 2023

Follow-up to #1603. Needed to support levels with schema validator.

xref bids-standard/bids-examples#413

@effigies effigies added schema Issues related to the YAML schema representation of the specification. Patch version release. exclude-from-changelog This item will not feature in the automatically generated changelog labels Nov 2, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47d912d) 87.83% compared to head (355ae6e) 87.83%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1648   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files          16       16           
  Lines        1356     1356           
=======================================
  Hits         1191     1191           
  Misses        165      165

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sappelhoff sappelhoff merged commit c10302d into bids-standard:master Nov 7, 2023
27 checks passed
@sappelhoff
Copy link
Member

Thanks @effigies

@sappelhoff
Copy link
Member

we will potentially add RotationRule and so on from:

like we did for the legacy validator in:

see also:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sappelhoff sappelhoff sappelhoff approved these changes

@Remi-Gau Remi-Gau Remi-Gau approved these changes

@tsalo tsalo Awaiting requested review from tsalo

@erdalkaraca erdalkaraca Awaiting requested review from erdalkaraca erdalkaraca is a code owner

Assignees
No one assigned
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@effigies @sappelhoff @Remi-Gau