[SCHEMA] - Adding validator to CLI #1641

suleesan · 2023-10-26T23:54:06Z

In main.py, working to add CLI hook for validator function.

for more information, see https://pre-commit.ci

effigies

Great start! I've had a quick look through, and here are some suggestions. Overall, I think there's a lot in this function we don't want to expose to a CLI user.

tools/schemacode/bidsschematools/__main__.py

Co-authored-by: Chris Markiewicz <[email protected]>

suleesan and others added 2 commits October 26, 2023 16:47

hello

74cb9b2

[pre-commit.ci] auto fixes from pre-commit.com hooks

22a5332

for more information, see https://pre-commit.ci

effigies reviewed Nov 2, 2023

View reviewed changes

tools/schemacode/bidsschematools/__main__.py Outdated Show resolved Hide resolved

tools/schemacode/bidsschematools/__main__.py Outdated Show resolved Hide resolved

tools/schemacode/bidsschematools/__main__.py Outdated Show resolved Hide resolved

Apply suggestions from code review

c9f9497

Co-authored-by: Chris Markiewicz <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SCHEMA] - Adding validator to CLI #1641

[SCHEMA] - Adding validator to CLI #1641

suleesan commented Oct 26, 2023

effigies left a comment

[SCHEMA] - Adding validator to CLI #1641

Are you sure you want to change the base?

[SCHEMA] - Adding validator to CLI #1641

Conversation

suleesan commented Oct 26, 2023

effigies left a comment

Choose a reason for hiding this comment