SCHEMA: Make expression tests more manageable #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rwblair |
effigies
force-pushed
the
schema/update-expression-tests
branch
from
7f85762
to
ff19470
Compare
effigies
added
schema
|
Do we know if anyone else uses these expression checks? |
rwblair
approved these changes
Oct 19, 2023
|
No, I don't think anybody does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started with a pretty ambitious expression language, thinking it would not be hard to implement in any language. It turns out that it would require a proper parser, which would probably be an intolerable slowdown to the javascript implementation. Making
null"falsey" is enough, and we don't use much of the fall-through behavior we originally designed.A Python implementation will be able to do some type-checking on the expressions we actually have to make sure they stay in the bounds the JS implementation can handle.