Fix potential resource leak

bfabiszewski · Apr 3, 2017 · f15b348 · f15b348
1 parent f887711
commit f15b348
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/app/src/main/java/net/fabiszewski/ulogger/GpxExportService.java b/app/src/main/java/net/fabiszewski/ulogger/GpxExportService.java
@@ -182,11 +182,11 @@ private void writePositions(@NonNull XmlSerializer serializer)
             throws IOException, IllegalArgumentException, IllegalStateException {
 
         Cursor cursor = db.getPositions();
-        serializer.startTag(null, "trkseg");
 
         // suppress as it requires target api 19
         //noinspection TryFinallyCanBeTryWithResources
         try {
+            serializer.startTag(null, "trkseg");
             while (cursor.moveToNext()) {
                 serializer.startTag(null, "trkpt");
                 serializer.attribute(null, "lat", cursor.getString(cursor.getColumnIndex(DbContract.Positions.COLUMN_LATITUDE)));
@@ -200,11 +200,10 @@ private void writePositions(@NonNull XmlSerializer serializer)
                 writeTag(serializer, "name", cursor.getString(cursor.getColumnIndex(DbContract.Positions._ID)));
                 serializer.endTag(null, "trkpt");
             }
+            serializer.endTag(null, "trkseg");
         } finally {
             cursor.close();
         }
-
-        serializer.endTag(null, "trkseg");
     }
 
     /**