[WIP] Fix: Report aggregation for jacoco #826
Conversation
github-actions
bot
added
operator
github-actions
bot
removed
operator
pom.xml
Outdated
| <execution> | ||
| <id>default-report</id> | ||
| <phase>verify</phase> | ||
| <goals> | ||
| <goal>report-aggregate</goal> | ||
| </goals> | ||
| <configuration> | ||
| <includeCurrentProject>true</includeCurrentProject> | ||
| <formats> | ||
| <format>XML</format> | ||
| </formats> | ||
| </configuration> | ||
| </execution> |
There was a problem hiding this comment.
The sonar.yml job is looking for the jacoco.xml files in target/site/jacoco and report-aggregate puts them in target/site/jacoco-aggregate. You should be able to add <outputDirectory>${project.reporting.outputDirectory}/jacoco</outputDirectory> to override it to the expected location.
Also, just a nit - but this XML block can be indented.
There was a problem hiding this comment.
Oh yes! I missed that change in this commit. But @MikeEdgar one concern/question I have is that
Even with these changes, in the operator index.html we see api and common coverage but not operator coverage. Same for sync. I think we are missing something here. What do you think?
I experimented with report and report-aggregate but had no luck.
There was a problem hiding this comment.
Something is definitely still not right... I'm checking now too.
|
Kudos, SonarCloud Quality Gate passed!
|
|
FYI, version 0.8.9 of the JaCoCo plugin was released. |
But Mike, the version hasn't been released to the maven repo can we still use the 0.8.9 in our pom ? |
|
@biswassri , that repo is a not current. See Maven Central. It was only just tagged a few days ago. |
Oh okay! Thanks for letting me know. |
No description provided.