fix: ensure image build uses correct architecture for macos #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running any of the image build make targets on an m1 macos, it fails due to the following error: qemu-x87_64: Could not open '/lib64/ld-linux-x86-64.so.2 This change specifies the platform to ensure build uses the correct architecture on macos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running any of the image build make targets on an m1 macos, it fails due to the following error in
RUN make binarystep:This change specifies the platform to ensure build uses the correct architecture on MacOS. Similar changes were done for KFM, see bf2fc6cc711aee1a0c2a/kas-fleet-manager#1602
Verification Steps
make image/buildormake image/build/internalormake image/build/devChecklist (Definition of Done)
All acceptance criteria specified in JIRA have been completedUnit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)Documentation added for the featureRequired metrics/dashboards/alerts have been added (or PR created).Required Standard Operating Procedure (SOP) is added.JIRA has created for changes required on the client side