CC article C++ Core Guidelines (#2110) #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Needed to property format the `[<citation-name>]:` lines * wikize-refs.py only supports a max of three references inside of a <sup></sup> block. I will commit the wikize-refs.py updated file next.
There is the same off-by-one error with the numbering of these that I will fix next (and then never run wikize-refs.py again).
* Fix off-by-one generation error * Remove period at the end of GSL reference that messed up a bunch of things * Changed order of [9] and [10] I manually tested these links and they seem to work.
This should be ready to review and hopefully publish with minor corrections.
Now this should be ready for final review and publishing
bartlettroscoe
added
the
preview
|
The generated page is shown at: The formatting looks reasonable. |
|
@ksbeattie, if you have a minute, could you please look over this and see if you notice any problems? |
|
I had time so I looked at it and its nicely written @bartlettroscoe @ksbeattie : could you review at the earliest so that we can push it out asap |
There were a few issues, including some typos that I noticed when reading over this again. Grammarly is not perfect :-(
ksbeattie
approved these changes
Aug 26, 2024
|
@betterscientificsoftware/bssw-maint, this should be ready to publish (see above checklist). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EB Member: @ksbeattie
Resolves #2110
PR checklist for files displayed on bssw.io site
@mentionthe BSSw.io editorial board member@<eb-member-id>in Description above assigned to shepherd your PR.<issue-id>in the Description above for the associated GitHub Issue.wikize_refs.py -i <base>.mdis run and commit (if using wikize_refs.py) ... I ran once and then had to manually fix issues with wikzie-refs.py (will not run again)*.mdfile(s) as rendered in GitHub for this PR.<eb-member-id>.<pr-author-id>.content: <content-type>for the type of contribution.Content Development(see Content Development).*.mdfile(s) (setPublish: yes).preview(so PR branch will be merged to 'preview' branch and watch for possible merge failures).[ ] [Author] EnsureCan't rebuild, see abovewikize_refs.py -i <base>.mdis run and commit (if using wikize_refs.py).@betterscientificsoftware/bssw-maint(BSSw Maint) asking to carry out final publication steps.NOTE:
@betterscientificsoftware/bssw-maintteam (hint: type@,b,s,s,w,-,mto auto-complete to@betterscientificsoftware/bssw-maint).©2024 The Better Scientific Software (BSSw.io) website. All rights reserved.