Skip to content

Commit

Permalink
Make the queue list work for everyone who can see the queue.
Browse files Browse the repository at this point in the history
Lots of users find the list useful, even if they cannot see everything
in the queue.

For example, being able to see the tickets you created in various queues
is quite useful, even if you do not have the SeeTicket permission for
those queues.
  • Loading branch information
chutzimir committed Jul 21, 2022
1 parent 7696687 commit 1714cd7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion share/html/Elements/QueueList
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ my $unwanted = $session{'CurrentUser'}->UserObj->Preferences('QueueList', {});
my $comp = $SplitByLifecycle? '/Elements/QueueSummaryByLifecycle' : '/Elements/QueueSummaryByStatus';
my $cache_key = SetObjectSessionCache(
ObjectType => 'RT::Queue',
CheckRight => 'ShowTicket',
CheckRight => 'SeeQueue',
ShowAll => 0,
CacheNeedsUpdate => RT->System->QueueCacheNeedsUpdate,
Exclude => $unwanted,
Expand Down
2 changes: 1 addition & 1 deletion share/html/Elements/QueueSummaryByLifecycle
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ my $data = {};
my $statuses = {};

use RT::Report::Tickets;
my $report = RT::Report::Tickets->new( RT->SystemUser );
my $report = RT::Report::Tickets->new( $session{'CurrentUser'} );
my $query =
"(Status = '__Active__') AND (".
join(' OR ', map "Queue = ".$_->{Id}, @$queues)
Expand Down
2 changes: 1 addition & 1 deletion share/html/Prefs/QueueList.html
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ <h1><&|/l&>Select queues to be displayed on the "RT at a glance" page</&></h1>
my $Queues = RT::Queues->new($session{'CurrentUser'});
$Queues->UnLimit;

my $right = 'ShowTicket';
my $right = 'SeeQueue';
$m->callback(
CallbackName => 'ModifyQueues',
Queues => \$Queues,
Expand Down

0 comments on commit 1714cd7

Please sign in to comment.