Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution guidance for Tools page #153

Conversation

foster999
Copy link
Contributor

Aiming to get more user input on tools that are useful for reproducible analysis. Adding clear guidance on how to contribute to this page.

@foster999 foster999 linked an issue May 31, 2023 that may be closed by this pull request
Copy link
Contributor

@rowanhemsi rowanhemsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments but in general this looks like a good update

book/tools.md Outdated Show resolved Hide resolved
book/tools.md Show resolved Hide resolved
book/tools.md Outdated Show resolved Hide resolved
book/tools.md Outdated Show resolved Hide resolved
book/tools.md Show resolved Hide resolved
book/tools.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
book/tools.md Outdated Show resolved Hide resolved
@rowanhemsi
Copy link
Contributor

Do we need to add a disclaimer saying that whilst we believe these tools are useful, we have not comprehensively quality assured or security checked them all and are not liable should any issues arise

Copy link
Contributor

@robertswh robertswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed disclaimer wording on using the tools.

Copy link
Contributor

@rowanhemsi rowanhemsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested have been implemented or an issue created to discuss. Happy for this to now be merged

@rowanhemsi rowanhemsi merged commit bc3b487 into main Jun 13, 2023
@rowanhemsi rowanhemsi deleted the 134-update-contribution-guidance-for-adding-new-tools-to-the-list branch June 13, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update contribution guidance for adding new tools to the list
3 participants