Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix hoverlabels #59

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Bugfix hoverlabels #59

merged 3 commits into from
Sep 14, 2023

Conversation

shilohd
Copy link
Contributor

@shilohd shilohd commented Sep 14, 2023

A fix for issue #58.

This came from an earlier code change that set the bar order by value. The hover labels were changed at the time, but not the value, meaning the values were in reverse order for vertical charts.

Please check that the chart now renders correctly.

this bug resulted from an earlier bugfix that set the order of bars but was not applied to the hover labels
@shilohd shilohd added the bug Something isn't working label Sep 14, 2023
@shilohd shilohd self-assigned this Sep 14, 2023
Copy link
Collaborator

@ldavies99 ldavies99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hover labels have been fixed but there are still issues:

  • The order of the plot is reversed compared to the table.
  • "Code packages" is being mislabelled as basic instead of advanced.

@ldavies99
Copy link
Collaborator

ldavies99 commented Sep 14, 2023

The hover labels have been fixed but there are still issues:

  • The order of the plot is reversed compared to the table.
  • "Code packages" is being mislabelled as basic instead of advanced.

Just needed to reinstall the package. Changes are all good.

@ldavies99 ldavies99 merged commit 85bce67 into main Sep 14, 2023
3 checks passed
@ldavies99 ldavies99 deleted the bugfix-hoverlabels branch September 14, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants