-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr/1.4.6 #246
Merged
Merged
Pr/1.4.6 #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BernardoFerreira
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job initializing the refactoring process of the back-end and improving the documentation to leverage f3dasm on HPC. A few bugs were also fixed, namely those unexistent hyperlinks to quickly jump to the Classes docs - nice!
Good to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes
_Data
that relies on lists instead of pd.DataFrame. This has not yet replaced the pandas back-end but tests are passing with the new_newdata.py
module.Domain.from_yaml
._Data.fill_output
methodfloat
instead ofnp.ndarray[float]
. Necessary to pass tests for new back-end, won't affect pandas back-end.Minor changes
ExperimentSample
code to be more robust to changes in the back-endtry_import
; import checks are moved to extension packages__version__.py
fileBugfixes
Domain
to also compare foroutput_space
attribute