Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/1.4.6 #246

Merged
merged 30 commits into from
Dec 7, 2023
Merged

Pr/1.4.6 #246

merged 30 commits into from
Dec 7, 2023

Conversation

mpvanderschelling
Copy link
Collaborator

@mpvanderschelling mpvanderschelling commented Nov 30, 2023

Major changes

  • Added documentation on SLURM job scheduler. Added sphinx-tabs as dependency when building documentation.
  • WIP: New back-end of _Data that relies on lists instead of pd.DataFrame. This has not yet replaced the pandas back-end but tests are passing with the new _newdata.py module.
  • Removed unused method Domain.from_yaml.
  • Removed unused _Data.fill_output method
  • Output of benchmark functions is now a float instead of np.ndarray[float]. Necessary to pass tests for new back-end, won't affect pandas back-end.

Minor changes

  • Refactoring parts of the ExperimentSample code to be more robust to changes in the back-end
  • Moving factory methods to appropriate modules
  • Removed try_import; import checks are moved to extension packages
  • Added __version__.py file
  • Updated docstrings to remove leading spaces

Bugfixes

@mpvanderschelling mpvanderschelling added the to main This merge is done to the main branch label Nov 30, 2023
@mpvanderschelling mpvanderschelling marked this pull request as ready for review November 30, 2023 14:26
Copy link
Collaborator

@BernardoFerreira BernardoFerreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job initializing the refactoring process of the back-end and improving the documentation to leverage f3dasm on HPC. A few bugs were also fixed, namely those unexistent hyperlinks to quickly jump to the Classes docs - nice!

Good to go!

@mpvanderschelling mpvanderschelling merged commit 7f96e7e into main Dec 7, 2023
37 checks passed
@mpvanderschelling mpvanderschelling deleted the pr/1.4.6 branch December 7, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to main This merge is done to the main branch
Projects
None yet
2 participants