-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr/1.4.5 #233
Pr/1.4.5 #233
Conversation
Mpvanderschelling/issue208
Mpvanderschelling/issue213
Remove the naming discrepancy (`path_`) of referenced to_disk=True object
…s in a list Fixes #201
added different set_x0 selection modes
Add a method to ExperimentData that extracts all the ExperimentSamples in a list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with this new release version, a lot of major updates that will significantly improve f3dasm functionality for sure! Please review the few comments that I left before approval.
Thank you for the less "functionality" improvements such as the compliance with the BRG guidelines and the private leading _ convention. Nonetheless, I point out that there are some modules that still don't have the correct BRG header format and several functions/methods/classes that don't have docstrings (namely private ones). These should be fixed for the next CRW (December 5).
This pull request will update the
main
code to version 1.4.5Major updates
Domain
andParameter
classesParameter
classes are now private. The suggested way to add parameters to a Domain will be with the publicadd_float
,add_int
,add_category
andadd_constant
methods.Domain.add
method to require the type and arguments of the (private) parameter to construct, instead of requiring the private Parameter objectExperimentData
classExperimentSample
objects or a selection ofExperimentSample
objects from anExperimentData
object.filename
attribute inExperimentData
: the name of the stored objects are hardcoded.path
attribute to the.project_dir
attribute. When storing theExperimentData
object with the.store()
method, a subdirectory (/experiment_data/
) will be created and the input data, output data, domain and jobs will be stored there.Optimizer
class_Data
class_Data
class to a separate private_Columns
class. This makes it more flexible for future development on the generalization of different back-ends (currently pandas) for_Data
Domain
to_Data
classStoring output data
path_
prefix before the parameter. This information is stored within the_Columns
objectExperimentSample.output_data
will, if applicable, load the output parameters from disk automaticallyExperimentSample.output_data_with_references
will give you the paths of the referencesExperimentSample.output_data_loaded
(will redirect toExperimentSample.output_data
Documentation
Bessa Group Coding Guidelines
Miscellaneous
_
).Closed issues