This repository has been archived by the owner on Nov 2, 2022. It is now read-only.
Small bugfixes #58
Open
Small bugfixes #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanunderwood
suggested changes
Dec 12, 2020
| @@ -23,3 +23,4 @@ samba_local_master: 'yes' | |||
| samba_domain_master: 'yes' | |||
| samba_preferred_master: 'yes' | |||
| samba_mitigate_cve_2017_7494: true | |||
| samba_python2: true | |||
There was a problem hiding this comment.
To make this work on Fedora 33 I had to change this to false. Looking at the logic, I think this actually should default to false, and be set to true for the platforms that need it? Or, I suppose it could just be set to true for Fedora.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed these changes to make it work on Fedora 32 and Ansible 2.9.9 with Python 3.
Passwords and usernames should be treated as literal strings in case they contain special characters that can be interpreted by the shell (like
$).