Fix CI [ part 2 ] #645
Fix CI [ part 2 ] #645
Conversation
chaadow
force-pushed
the
update_ci
branch
4 times, most recently
from
f9dc26d
to
d31f93d
Compare
|
@seuros All good the CI is green! |
lib/best_in_place/railtie.rb
Outdated
| @@ -4,7 +4,7 @@ | |||
| module BestInPlace | |||
| class Railtie < ::Rails::Railtie #:nodoc: | |||
| config.after_initialize do | |||
| BestInPlace::ViewHelpers = ActionView::Base.new({}, {}, "") | |||
| BestInPlace::ViewHelpers = ActionView::Base.respond_to?(:empty) ? ActionView::Base.empty : ActionView::Base.new | |||
There was a problem hiding this comment.
Do we need this condition ? I think all versions need .empty
lib/best_in_place/engine.rb
Outdated
| ActiveSupport.on_load(:action_controller) do | ||
| ActionView::Base.send(:include, BestInPlace::Helper) | ||
|
|
||
| ActionController::Base.send(:include, BestInPlace::ControllerExtensions) |
There was a problem hiding this comment.
This can be just "include BestInPlace.
| - rails_7.0 | ||
| - rails_7.1 | ||
| - rails_7.2 | ||
| - rails_edge | ||
| env: | ||
| RAILS_ENV: test | ||
| DISPLAY: ":99.0" | ||
| BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.rails }}.gemfile |
|
Thanks for fixing the build. I tried to fix it from the browser and github went offline haha |
|
Do we need to merge anything or any open PR ? Else I we can bump major version and release. |
|
@seuros that's what i'm trying to figure out, just give me an hour or so and I'll let you know |
|
Thanks for merging! |
|
@seuros I think we can release for now, everything works on my production app, the most important bits have already been handled in my PR. |
|
Released as 4.0.0 |
|
Thanks! |
No description provided.