-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to use different input types #544
base: master
Are you sure you want to change the base?
Conversation
…x_wait_time instead' in test_helpers
…y. Fixed them by creating application.css and including it in application.html.erb instead of separate css files
Also there were rspec failures in rails-4.2 enviroment. If I understand correctly, they were caused by sprocked v3.0 |
I wonder why this havn't been merged yet, also duplicate of #551 |
This would be very helpful. Anything we can do to get this moved forward? |
Thanks this post helped me a lot and i made the changes in my best_in_place.js file according to your commit and my code is successfully working 👍 |
HTML5 introduced new handy input types like number, url, etc. and some basic validations.
I've tried to pass additional options to bip_helper in html_attrs params like
I've checked sources and see that input editor assumes that input always has 'text' type.
I've modified javascript to allow other input types.
now it works for me