-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.4+: use os.set_inheritable + os.set_blocking in place of unreadable fcntl calls #3210
base: master
Are you sure you want to change the base?
Conversation
3ab0385
to
bc4fc46
Compare
Not disagreeing about this change but this must be validated on BSD. I think we need to add FreeBSD to our test platform to ensure it works there. (an dmaybe other OpenBSD). |
facf3b6
to
2551f70
Compare
b5a25e9
to
4831ef3
Compare
@benoitc Happy with pulling Neil Pang's vm images? Those work with very little setup required for FreeBSD, OpenBSD and illumos (no prebuilt gevent though). Though the Github file still needs review by someone more proficient with that:
|
4831ef3
to
5632dc0
Compare
5632dc0
to
a452f12
Compare
workaround greenlet installation on OmniOS v11: libev assumes inotify.h must be Linux. make autoconf stop offering it.
f8bda39
to
0d03ef2
Compare
We should cleanup those rather unreadable low-level fcntl calls. The stdlib provides single-call functions for these now.
(Replacement is not 100% equivalent, as they might call
ioctl(.., FIO.., NULL)
instead, but I see no reason we should care.)Suggested order:
.fileno()
suffixes that might to be dropped