CHE-202_bug_causes_array_push_error

[BuggerBugs]

No description provided.

[BuggerBugs]

Error was caught and fixed in chessis.fun. Description is here for logging purposes!:

Error is sometimes thrown at specific cases which causes analysis to fail.
Errorwas that we were pushing into a null object.
Apparently it's because within captures.ts KDRatioMetric, within the aggregate() function, pieceWithHighestKDRatio and pieceWithHighestKDRatioValues were initialised as null(). The following case probably triggered the error:

maxKDRatio is initalised as 0.

The First value of KDRatios[uas] iterating through the for loop is 0.

That means KDRatios[uas]===maxKDRatio, hence we push the UAS symbol of said KDRatio into pieceWithHighestKDRatio. BUT pieceWithHighestKDRatio is null. Hence we are trying to push into a null object in this case.

The exact same issue occurs with pieceWithHighestKDRatioValues.

Fix: Initialised both piece pieceWithHighestKDRatio and pieceWithHighestKDRatioValues as empty arrays instead of null.

[bennyrubanov]

is this a new file? why is it being presented as such?

[BuggerBugs]

Thanks for pointing this out! Responded in linear! https://linear.app/chess-analysis/issue/CHE-202/bug-causes-array-push-error-to-be-thrown-during-analysis#comment-6e2f0c6f