Add more metrics and clean up old code #40

EllAchE · 2023-11-04T08:46:25Z

No description provided.

.github/workflows/node.js.yml

bennyrubanov · 2023-11-07T05:09:05Z

src/index.ts

-    // console.log(`lichess link to game played: ${siteLink}`);
+    for (const metric of metrics) {
+      const historyGenerator = cjsmin.historyGenerator(game.moves);
+      metric.processGame(Array.from(historyGenerator), siteLink);


if i understand this correctly, we are processing siteLink for every game, not just the ones that "win" the metric? that seems inefficient

it is. I think below you mention passing the metadata. We can do that instead and it's probably a better pattern

bennyrubanov · 2023-11-07T05:33:00Z

src/metrics/distances.ts

+      if (singleGameMap[uas].total > this.pieceMaxes.distance) {
+        this.pieceMaxes.uasArray = [uas as UASymbol];
+        this.pieceMaxes.distance = singleGameMap[uas].total;
+        // this.singleGameMaxPiece.link = undefined; // TODO: add game link support


how can we pull out metadata data from the game being processed? shouldn't it be similar given this is under a for loop with games passed to it? is the issue that the move and board don't contain the metadata?

if yes, we just need to add the metadata as a third array as part of game no?

now passing md

bennyrubanov · 2023-11-07T07:00:22Z

src/metrics/distances.ts

-  };
-}
+  logResults(): void {
+    console.timeEnd('Task 2: getMoveDistanceSetOfGames');


this needs to be changed as this function name is obsolete?

bennyrubanov · 2023-11-07T07:03:34Z

src/metrics/distances.ts

+  maxAvgDistance: number;
+  minAvgDistance: number;
+  totalDistance: number;
+  maxSingleGameTotal: number;


should be maxSingleGameDistance no?

using this in all spots now

bennyrubanov · 2023-11-07T07:04:20Z

src/metrics/distances.ts

+    for (const uas of Object.keys(singleGameMap)) {
+      this.distanceMap[uas].total += singleGameMap[uas].total;
+      if (
+        singleGameMap[uas].total > this.distanceMap[uas].maxSingleGameDistance


where does maxSingleGameDistance come from? you have defined maxSingleGame, and maxSingleGameTotal, but not maxSingleGameDistance. i think you might be using both maxSingleGameTotal and maxSingleGameDistance for the same purpose, need to pick one

there are some typing issues with indexed based on the object mapper keys that I didn't want to deal with, one of these should be throwing a compiler error but it's masked by the object indexing. I've switched to just one

bennyrubanov · 2023-11-07T07:25:11Z

src/types.ts


 export interface FileReaderGame {
  moves: string;
  metadata: string[];
 }

+export type UAPMap<T> = {
+  [key in UASymbol]: T;


T as the key? to set it to something that wouldn't be used as starting value?

look up generic types

bennyrubanov · 2023-11-07T07:25:59Z

src/utils.ts

+}
+
+/**
+ * A utitily function to create an object with unambiguous piece symbols as keys


utility spelled wrong ;)

bennyrubanov · 2023-11-07T07:26:25Z

src/utils.ts

+  return map as { [key in UASymbol]: T };
+}
+
+export function createBoardMap<T extends Object>(object: T): BoardMap<T> {


in what contexts do you imagine these being used?

I'm using it rn

when we need a map of squares --> UAS --> some tracking counts

bennyrubanov · 2023-11-07T07:27:59Z

tests/enPassant.test.ts

@@ -3,7 +3,7 @@ import { Chess } from '../cjsmin/src/chess';

 const pgnEP = `1. d2d4 f7f5 2. b2b3 e7e6 3. c1b2 d7d5 4. g1f3 f8d6 5. e2e3 g8f6 6. b1d2 e8g8 7. c2c4 c7c6 8. f1d3 b8d7 9. e1g1 f6e4 10. a1c1 g7g5 11. h2h3 d8e8 12. d3e4 d5e4 13. f3g5 e8g6 14. h3h4 h7h6 15. g5h3 d7f6 16. f2f4 e4f3 17. d2f3 f6g4 18. d1e2 d6g3 19. h3f4 g6g7 20. d4d5 g7f7 21. d5e6 c8e6 22. f3e5 g4e5 23. b2e5 g8h7 24. h4h5 f8g8 25. e2f3 g3f4 26. e5f4 g8g4 27. g2g3 a8g8 28. c1c2 b7b5 29. c4b5 e6d5 30. f3d1 f7h5 31. c2h2 g4g3+ 32. f4g3 g8g3+ 33. g1f2 h5h2+ 34. f2e1 g3g2 35. d1d3 d5e4 36. d3d7+ h7g6 37. b5c6 g2e2+ 38. e1d1 e2a2 0-1`;

-xdescribe('Game history for en passant move should show valid captured piece', () => {
+describe('Game history for en passant move should show valid captured piece', () => {


test looks good to me. can you add expects for unambiguous pieces

all of your comments are above the code that actually matters. PR comments show the lines you select, or the 4 above your comment

I don't understand what you wan the test here to do

bennyrubanov · 2023-11-07T07:29:24Z

tests/queensidecastle.test.ts

@@ -1,6 +1,6 @@
 import { Chess } from '../cjsmin/src/chess';

-xdescribe('Queenside castling is detected', () => {
+describe('Queenside castling is detected', () => {


where does the .filter function come from? chess.js?

this is old test. Filter is a method applicable to arrays

EllAchE added 6 commits November 3, 2023 23:40

fix uas refactor

3aa3f68

add gh workflow

c7476da

remove redundant tests

ead77ea

update average distance to metric

67b162b

add chkmt to revenge kills

0ea6fb2

clean up some old tests and validate existing metrics

8528860

EllAchE requested a review from bennyrubanov November 4, 2023 08:46

EllAchE changed the title ~~clean up some old tests and validate existing metrics~~ Add more metrics and clean up old code Nov 4, 2023

EllAchE added 11 commits November 4, 2023 01:49

take only current

4fefad4

rename to UAS

3eb7a5e

consolidate metrics

b69d822

correct tests

02b9810

add test for promotions

eabd027

single game move max calcs

f4bf4bc

compiler fixes old cold

69005cb

add tests for the moves metric

ddf4ddd

updt shortpgn

8c75bce

add capture map

2184560

fix tests

71db4a8

bennyrubanov reviewed Nov 7, 2023

View reviewed changes

.github/workflows/node.js.yml Show resolved Hide resolved

play with optimization

5f4ab97

bennyrubanov approved these changes Nov 7, 2023

View reviewed changes

use metadata instead of gameLink

89b1aa6

EllAchE requested a review from bennyrubanov November 7, 2023 07:52

EllAchE merged commit a8e656c into main Nov 7, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more metrics and clean up old code #40

Add more metrics and clean up old code #40

EllAchE commented Nov 4, 2023

bennyrubanov Nov 7, 2023

EllAchE Nov 7, 2023

bennyrubanov Nov 7, 2023

EllAchE Nov 7, 2023

bennyrubanov Nov 7, 2023

EllAchE Nov 7, 2023

bennyrubanov Nov 7, 2023

EllAchE Nov 7, 2023

bennyrubanov Nov 7, 2023

EllAchE Nov 7, 2023

bennyrubanov Nov 7, 2023

EllAchE Nov 7, 2023

bennyrubanov Nov 7, 2023

bennyrubanov Nov 7, 2023

EllAchE Nov 7, 2023

EllAchE Nov 7, 2023

bennyrubanov Nov 7, 2023

EllAchE Nov 7, 2023

EllAchE Nov 7, 2023

bennyrubanov Nov 7, 2023

EllAchE Nov 7, 2023

Add more metrics and clean up old code #40

Add more metrics and clean up old code #40

Conversation

EllAchE commented Nov 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment