Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): Fix the plugin options config #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thaiat
Copy link

@thaiat thaiat commented Sep 29, 2015

FIxes #2

@bennyhat
Copy link
Owner

Hey Avi,
Thanks for looking into this. I have merged your change into a bugfix branch - https://github.com/bennyhat/protractor-istanbul-plugin/tree/bugfix/protractor-2.2-updates, which I'll publish to NPM as version 2.0.0 in a moment and let you know (skipping 1.0.0 as I screwed up my versioning early on). I will hopefully merge this into the master branch once I fix all of the unit tests to reflect your change. Unfortunately, I'm pretty sure that protractor 2.2 broke a few more things than just this, as they changed a lot of the function definitions (moving function references into the first arg for most of the hooks, for example).
Thanks!
Ben

@bennyhat
Copy link
Owner

All right - v2.0.0 is out on NPM for your immediate use. However, like I mentioned, it will not be merged into master until I get those units tests updated (and probably add some integration tests for protractor 2.2 as well).
Thanks!
Ben

@thaiat
Copy link
Author

thaiat commented Sep 29, 2015

thks @bennyhat
from what i can tell i have been using your plugin on a very large app with protractor 2.2 and everything is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants