Expose /pure build that doesnt depend on OS or require
#1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proof of concept - I would gladly work on this to move it through the finish line. However, those kinds of changes might really depend on personal preferences etc so I might need some guidance and code review to do that.
Why?
I'm using a Babel parser and I don't want to pull in a dependency like
esprimaif I don't have to.How?
/pureentrypoint. The name is questionable and I'm happy to change it - I've just wanted this to be terse and couldn't figure out a better one on the spotesprimaoption@babel/parser/babylonloadingrequire("os").EOL. I can bring it back in a similar fashion - by splitting the pure and impure files and only using this in the "impure" one