Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP serde_rustler 0.0.8 upgrade #25

Merged
merged 2 commits into from
Oct 28, 2023
Merged

WIP serde_rustler 0.0.8 upgrade #25

merged 2 commits into from
Oct 28, 2023

Conversation

lytedev
Copy link
Contributor

@lytedev lytedev commented Oct 27, 2023

No description provided.

benhaney
benhaney reviewed Oct 28, 2023
View reviewed changes
Copy link
Owner

@benhaney benhaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a tiny bit of cleanup. I'll do a release commit after

CHANGELOG.md Outdated Show resolved Hide resolved
native/jsonrs/Cargo.toml Outdated Show resolved Hide resolved
@benhaney benhaney marked this pull request as ready for review October 28, 2023 06:05
@benhaney
Copy link
Owner

Okay I guess I can just commit straight to your repo if you open a PR?

@benhaney benhaney merged commit d8e9aba into benhaney:master Oct 28, 2023
1 check passed
@lytedev
Copy link
Contributor Author

lytedev commented Oct 29, 2023

Yeah there's a fancy checkbox that gives access if you want.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhaney benhaney benhaney left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lytedev @benhaney