Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collisions: Disable ion-neutral and electron-neutral by default #242

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

bendudson
Copy link
Owner

These may be double-counted if atomic reactions are included. Added a note to the manual.

ion-electron, electron-electron, ion-ion, and neutral-neutral collisions are still enabled by default.

Fixes #241.

bendudson and others added 2 commits August 7, 2024 16:29
These may be double-counted if atomic reactions are included.
Added a note to the manual.
@mikekryjak
Copy link
Collaborator

How come you disabled e-n as well? Is that double counting something too?

@bendudson
Copy link
Owner Author

I don't think e-n are double counted, but I thought this might be the least surprising set of defaults.
electron-neutral collisions aren't included in e.g Braginskii rates, so if someone is comparing to Braginskii then they would need to remember to disable e-n collisions. This means that all plasma-neutral interactions must be explicitly turned on, which might be a simple rule to remember.

The electron-driven reactions don't modify the electron collision frequency (https://github.com/bendudson/hermes-3/blob/master/include/amjuel_reaction.hxx#L68).

Happy to change this default, if something else would be easier for people to work with.

@mikekryjak
Copy link
Collaborator

Hi @bendudson okay, I agree with that. There is a related question of what we do with the Braginskii collisionality implementation - whether we set Braginskii as default or not. I think that default should be Braginskii, and documentation and possibly a warning should warn the user if they are using multiple ions. I asked the question here: #195

@bendudson bendudson merged commit d2245ff into master Aug 8, 2024
3 checks passed
@bendudson bendudson deleted the default-collisions branch August 8, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to disable ion-neutral collisions by default
2 participants