Skip to content

Commit

Permalink
Improve 1D neutral cond/visc flag names
Browse files Browse the repository at this point in the history
  • Loading branch information
mikekryjak committed May 23, 2024
1 parent 0a2b058 commit e652bf7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions include/neutral_parallel_diffusion.hxx
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ struct NeutralParallelDiffusion : public Component {
.doc("Fix correcting pressure advection and conductivity factors?")
.withDefault<bool>(true);

thermal_conduction = options["thermal_conducton"]
.doc("Enable conduction?")
perpendicular_conduction = options["perpendicular_conduction"]
.doc("Enable parallel projection of perpendicular conduction?")
.withDefault<bool>(true);

viscosity = options["viscosity"]
.doc("Enable viscosity?")
perpendicular_viscosity = options["perpendicular_viscosity"]
.doc("Enable parallel projection of perpendicular viscosity?")
.withDefault<bool>(true);
}

Expand Down Expand Up @@ -80,8 +80,8 @@ private:
std::string diffusion_collisions_mode; ///< Collision selection, either afn or legacy
Field3D nu; ///< Collision frequency for conduction
bool equation_fix; ///< Fix incorrect 3/2 factor in pressure advection?
bool thermal_conduction; ///< Enable conduction?
bool viscosity; ///< Enable viscosity?
bool perpendicular_conduction; ///< Enable conduction?
bool perpendicular_viscosity; ///< Enable viscosity?

/// Per-species diagnostics
struct Diagnostics {
Expand Down
4 changes: 2 additions & 2 deletions src/neutral_parallel_diffusion.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,13 @@ void NeutralParallelDiffusion::transform(Options& state) {
// Heat transfer
Field3D E = + FV::Div_par_K_Grad_par(
Dn * advection_factor * Pn, logPn); // Pressure advection
if (thermal_conduction) {
if (perpendicular_conduction) {
E += FV::Div_par_K_Grad_par(kappa_n, Tn); // Conduction
}
add(species["energy_source"], E);

Field3D F = 0.0;
if (IS_SET(species["velocity"]) and viscosity) {
if (IS_SET(species["velocity"]) and perpendicular_viscosity) {
// Relationship between heat conduction and viscosity for neutral
// gas Chapman, Cowling "The Mathematical Theory of Non-Uniform
// Gases", CUP 1952 Ferziger, Kaper "Mathematical Theory of
Expand Down

0 comments on commit e652bf7

Please sign in to comment.