Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 17 #644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Java 17 #644

wants to merge 1 commit into from

Conversation

jaredsburrows
Copy link
Collaborator

@jaredsburrows jaredsburrows commented May 9, 2022

@ben-manes
Copy link
Owner

I think this is to be expected since Gradle does not support jdk18 yet

@jaredsburrows
Copy link
Collaborator Author

@jaredsburrows
Copy link
Collaborator Author

The documentation does seem to be updated - https://docs.gradle.org/current/userguide/compatibility.html.

@ben-manes
Copy link
Owner

yeah, other jdks may work or may not until officially supported. That is a bit annoying since it means one cannot test against EA builds and Gradle lags in their release cycle. They used to have 6 weeks releases between minor but lately it seems they are behind (7.4 was early Feb).

@jaredsburrows jaredsburrows mentioned this pull request Sep 15, 2022
@jaredsburrows jaredsburrows force-pushed the pr/jaredsburrows/java18 branch 2 times, most recently from 2487284 to ef5de88 Compare September 15, 2022 20:55
@OleksandrShkurat
Copy link

I'd suggest adding JDK 17 instead of 18 as it is the latest LTS version.

@tresat
Copy link
Contributor

tresat commented Apr 17, 2023

You should be able to merge this now, Gradle supports Java 19 as of 7.6.

The 6 week release cycle is something we're trying hard to get back to. It looks like 8.2 is going to follow very close on the heels of 8.1.

@ben-manes
Copy link
Owner

@jaredsburrows can you rebase and merge if all looks good?

@jaredsburrows
Copy link
Collaborator Author

@ben-manes Odd, there should be a "Update Branch" button. Can you go to the repo's settings? https://github.com/jaredsburrows/cs-interview-questions/settings and look for the following "Always suggest updating pull request branches ":
Screenshot 2023-04-28 at 12 57 33 PM

This way folks can update via github.com and then I can click on "Rebase and merge" before submitting.

@ben-manes
Copy link
Owner

done, good catch!

@jaredsburrows jaredsburrows changed the title Java 18 Java 17 Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants