Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ [Eslint] Switch to flat config #84

Merged
merged 45 commits into from
Jul 31, 2024
Merged

🛠️ [Eslint] Switch to flat config #84

merged 45 commits into from
Jul 31, 2024

Conversation

beefchimi
Copy link
Owner

@beefchimi beefchimi commented Jun 7, 2024

After struggling for far too long to get everything switched over to eslint v9 + flat config... I've settled on completely switching over to antfu/eslint-config.

This introduces many changes. Some highlights:

  • Bumped versions of node + pnpm.
  • Many other small package bumps.
  • Removed prettier, as eslint is now responsible for formatting.
  • Some formatting regressions (documented below).

Follow-up tasks

  • Can import/order be improved so that relative paths are enforced as the last imports?
  • .ts within markdown does not appear to work. Getting errors for type declarations.
    • Once fixed, remove all instances of <!-- eslint-skip -->.
  • Check in on instances of // eslint-disable-next-line ts/return-await.
    • There are several instances where I am using this, and we may want to rethink that.
  • Fix broken if/else statements.
    • Search for else with spaces.
  • Would be nice if I could differentiate between ternary and if conditions, so that the || / && operators are:
    • At the beginning for multi-line ternaries.
    • At the end for multi-line if statements.

@beefchimi beefchimi self-assigned this Jun 7, 2024
Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: 667b837

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
website Minor
earwurm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🧰 Dependency Any dependency change (add / remove / downgrade / update) 📚 Documentation Improvements or additions to documentation 🛠️ Tooling Relating to build tooling or deployment labels Jun 7, 2024
@github-actions github-actions bot added the 🧪 Testing Relating to testing of this code label Jul 30, 2024
@beefchimi beefchimi marked this pull request as ready for review July 31, 2024 14:40
@beefchimi beefchimi merged commit fba1989 into main Jul 31, 2024
3 checks passed
@beefchimi beefchimi deleted the flat branch July 31, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧰 Dependency Any dependency change (add / remove / downgrade / update) 📚 Documentation Improvements or additions to documentation 🧪 Testing Relating to testing of this code 🛠️ Tooling Relating to build tooling or deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant