forked from carlossg/kaniko
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkins #1
Open
beedemo-admin
wants to merge
112
commits into
master
Choose a base branch
from
jenkins
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Jenkins #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor copy and add Add/copy pass integration tests
To run with jenkins kubernetes plugin
Using --insecure-skip-tls-verify
…-copy Refactor copy and add
* Add support for insecure docker registry Using --insecure-skip-tls-verify Fixes GoogleContainerTools#110 * Apply formatting
Updated vendor
It's not really needed to use config.json credentials
Works with the standard kaniko docker image
…ntainerTools#139) * Add whiteout handling by switching to a two-phase approach. Also only handle hardlinks within one layer * Simplify the run test.
Update readme -- kaniko doesn't support Windows
Release executor based off debian for debugging
Update readme for debug image
Add shell command to commands.go
Ignore symlinks during file extraction if link is whitelisted
Add credential helper and documentation for pushing to Amazon ECR
Create debug image with busybox shell
Add busybox to path for debug image
The previous document did not mention that Docker runs as root, and so some of the benefits of the tools being compared (such as img, orca-build, and umoci) were not properly explained. This is quite important because while Kubernetes users have Docker installed (on most clusters), on local machines and non-Kubernetes workloads the story is quite different. Signed-off-by: Aleksa Sarai <[email protected]>
README: slight corrections about privileges
* added basic healthcheck implementation * updated go-containerregistry version * added build args parameter to healthcheck execute * added go-containerregistry HealthCheck passing * dereferenced health for conversion
Support multi stage builds
Pass in clone of buildargs for dockerfile parsing
* integration test refactoring * config file cleanup * more test refactoring * remove debug file * moving around more files * fixing up integration tests * integration tests work * some housekeeping * fixing tests * addressing comments * debugging * debugging * actual debugging * skip integration tests for travis * install container-diff before integration tests * syntax * make test failures less noisy * fixing tests * hopefully fixing CI? * fixes * more fixes * let's actually fix CI * more testing * testing * proper auth * typos * adding support for args in integration tests * formatting * formatting * adding support for testing bucket context * adding bucket test dockerfile * addressing comments * syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy Dockerfile over