Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mypy config #179

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

feat: Mypy config #179

wants to merge 5 commits into from

Conversation

nstarman
Copy link
Contributor

Fixes #147

Plz don't squash.

Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
@nstarman
Copy link
Contributor Author

Hmm. Not sure what changed with python check_linter_assertions.py tests/typechecked.

@wesselb
Copy link
Member

wesselb commented Jul 3, 2024

@nstarman The error says that the script expected mypy to throw an error saying

no overload variant of "f" matches argument type "float"

but mypy didn’t. If you run mypy on test_overload.py, do you see that error? Maybe the additional type hints changed mypys error.

Plz don't squash.

Ah, you not like to squash and merge? Would you prefer another way?

@nstarman
Copy link
Contributor Author

nstarman commented Jul 3, 2024

I normally like Squash & Merge, but for this PR I was trying to keep each commit a distinct contribution: the configuration, then adding typing to each module. You can Squash & Merge, of course, I was just suggesting that for this PR a normal merge was appropriate.

@wesselb
Copy link
Member

wesselb commented Jul 3, 2024

@nstarman Ah, that makes total sense! Thanks for the explanation. I’m also happy to merge without squashing if the commits are nicely structured. I don’t feel strongly any particular way. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure mypy for CI
2 participants