Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: type annotate signature.py #172

Merged
merged 3 commits into from
Jun 28, 2024
Merged

feat: type annotate signature.py #172

merged 3 commits into from
Jun 28, 2024

Conversation

nstarman
Copy link
Contributor

Misc additional type hints to signature.py

@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9706322494

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.92%
Totals Coverage Status
Change from base Build 9692435229: 0.0%
Covered Lines: 1249
Relevant Lines: 1250
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9706481239

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.92%
Totals Coverage Status
Change from base Build 9692435229: 0.0%
Covered Lines: 1249
Relevant Lines: 1250
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9706551668

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.92%
Totals Coverage Status
Change from base Build 9692435229: 0.0%
Covered Lines: 1249
Relevant Lines: 1250
💛 - Coveralls

@nstarman
Copy link
Contributor Author

I don't think the failure is related. ?

@nstarman nstarman marked this pull request as ready for review June 28, 2024 04:07
@wesselb
Copy link
Member

wesselb commented Jun 28, 2024

@nstarman, no, the flaky test is becoming really annoying! I should investigate if something is off or whether the test is just too strict.

Thanks again for yet another PR!! Merging right away.

@wesselb wesselb merged commit 595690e into beartype:master Jun 28, 2024
1 check passed
@nstarman nstarman deleted the signature branch June 28, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nstarman @coveralls @wesselb