Fix build break (stack overflow) for no-cv-ss building (#2500)

be5invis · Sep 13, 2024 · 6de1457 · 6de1457
1 parent 9d17e38
commit 6de1457
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.github/workflows/pr-build-validation.yml b/.github/workflows/pr-build-validation.yml
@@ -10,7 +10,7 @@ jobs:
 
     strategy:
       matrix:
-        fontName: ["Iosevka", "IosevkaSlab", "IosevkaAile", "IosevkaEtoile"]
+        fontName: ["Iosevka", "IosevkaSlab", "IosevkaAile", "IosevkaEtoile", "IosevkaNoVarTest"]
 
     steps:
       # Checkout repository into `iosevka` sub directory

diff --git a/build-plans.toml b/build-plans.toml
@@ -875,6 +875,13 @@ shape = 700
 menu = 700
 css = 700
 
+[buildPlans.IosevkaNoVarTest]
+family = "IosevkaNoVarTest"
+spacing = "normal"
+serifs = "sans"
+noCvSs = true
+exportGlyphNames = false
+
 ###################################################################################################
 # Collect plans
 

diff --git a/packages/glyph/src/glyph.mjs b/packages/glyph/src/glyph.mjs
@@ -145,7 +145,7 @@ export class Glyph {
 
 	tryBecomeMirrorOf(dst, rankSet) {
 		if (rankSet.has(this) || rankSet.has(dst)) return;
-		if (dst.hasDependency(this)) return;
+		if (this === dst || dst.hasDependency(this)) return;
 		const csThis = Geom.hashGeometry(this.geometry);
 		const csDst = Geom.hashGeometry(dst.geometry);
 		if (csThis && csDst && csThis === csDst) {