Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6178] CORE project summary edit mode bugs, contd #3285

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Oct 28, 2024

Objective

Project Dates:

  • make validation messages more useful
  • throw in some spacing
  • allow user to clear the date
  • sorry, lots of whitespace differences on this now!

Project Links:

  • hide the input part of it altogether when in view mode
  • doing so also fixed the state issues where (I believe) the currentSelection was staying the same between edit/view toggle, making it so that clicking the add button after toggling back to edit was adding what was previously there (even though it wasn't in the select box anymore). The re-render fixed it.
  • and make sure that after adding the related project that the selection was cleared.

General Project summary form:

  • reset the form on cancel edit

MDS-6178

Why are you making this change? Provide a short explanation and/or screenshots
image

Copy link

sonarcloud bot commented Oct 28, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 28, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
55.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 28, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
30.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

if (!invalid) {
return undefined;
}
const otherFormattedDate = moment(other).format("ddd MMM D YYYY");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see these converted to using DateFns instead of moment at some point. But I think we have a ticket to throw moment in the garbage already, so maybe it can wait for that.

@taraepp taraepp merged commit 7ff40b9 into develop Oct 29, 2024
14 of 15 checks passed
@taraepp taraepp deleted the mds-6178-add-button branch October 29, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants