[MDS-6103] Upgraded build related npm packages + upgraded codebase to support newest sass version #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
simensma-fresh
added
🌶 Enhancement
matbusby-fw
reviewed
Oct 24, 2024
| @import "~@syncfusion/ej2-grids/styles/material.scss"; | ||
| @import "~@syncfusion/ej2-react-pdfviewer/styles/material.scss"; | ||
| @import "~@syncfusion/ej2-react-filemanager/styles/material.scss"; | ||
| @import "~@syncfusion/ej2-base/styles/material.css"; |
There was a problem hiding this comment.
Interesting. Was this a change on the Syncfusion side of things? Or were there never scss versions of these?
matbusby-fw
approved these changes
Oct 24, 2024
asinn134
reviewed
Oct 24, 2024
asinn134
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-6103
SASS Upgrade
@importstatements are present (these conflict with the plaincssversion). Instead, we should use the SASS module system (good writeup here: https://css-tricks.com/introducing-sass-modules/ )darken) to use the namespaced ones instead (e.g. color.adjust) to remove a bunch of warnings. This was done automatically using thesass-migrationcommandbase.scssfile that contains most of the old global utilityscss(variables / theme etc.). I added this to make this migration a bit more achievable, but it might be a good idea to instead use direct imports where we can instead.Package upgrades