Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6179] Refactored ProjectOverviewTab.js to a functional Typescript Component #3253

Merged
merged 11 commits into from
Sep 25, 2024

Conversation

matbusby-fw
Copy link
Collaborator

Navigating into view in a project summary was incorrectly navigating the user to the edit screen with an undefined value in the url. After refactoring the component it seems to be picking up the correct routing and navigating the user to the view screen where they can then navigate to view details (and navigate back without experiencing the undefined value).

Ended up needing a little more work.

Backing out of viewing a detailed project summary was clearing the state of the projectSummary in the redux store. This seems to be intentional to prevent stale state from affecting other views. To make sure the projectSummary state existed in the ProjectsPage as necessary, I add some additional conditional logic to the fetch check to also refetch if the projectSummary isn't found.

Objective

MDS-6179

project-routing

…. This process seems to have fixed the issue.
…the store (this happens deliberately while backing out of viewing a detailed project summary as it prevents another bug where the state is incorrectly persisted.
@matbusby-fw matbusby-fw added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Sep 23, 2024
Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
72.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'

Failed conditions
63.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@matbusby-fw matbusby-fw merged commit 21acc0c into develop Sep 25, 2024
13 of 15 checks passed
@matbusby-fw matbusby-fw deleted the mds-6179-view_submitted_project_summary branch September 25, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants