-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS-6179] Refactored ProjectOverviewTab.js to a functional Typescript Component #3253
Merged
matbusby-fw
merged 11 commits into
develop
from
mds-6179-view_submitted_project_summary
Sep 25, 2024
Merged
[MDS-6179] Refactored ProjectOverviewTab.js to a functional Typescript Component #3253
matbusby-fw
merged 11 commits into
develop
from
mds-6179-view_submitted_project_summary
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. This process seems to have fixed the issue.
…the store (this happens deliberately while backing out of viewing a detailed project summary as it prevents another bug where the state is incorrectly persisted.
matbusby-fw
added
the
👍 Ready for review
Pull request has been double checked by the author and is ready for comments and feedback.
label
Sep 23, 2024
Quality Gate failed for 'bcgov-sonarcloud_mds_common'Failed conditions |
Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'Failed conditions |
Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'Issues Measures |
taraepp
approved these changes
Sep 25, 2024
asinn134
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
👍 Ready for review
Pull request has been double checked by the author and is ready for comments and feedback.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigating into view in a project summary was incorrectly navigating the user to the edit screen with an undefined value in the url. After refactoring the component it seems to be picking up the correct routing and navigating the user to the view screen where they can then navigate to view details (and navigate back without experiencing the undefined value).
Ended up needing a little more work.
Backing out of viewing a detailed project summary was clearing the state of the
projectSummary
in the redux store. This seems to be intentional to prevent stale state from affecting other views. To make sure the projectSummary state existed in the ProjectsPage as necessary, I add some additional conditional logic to the fetch check to also refetch if the projectSummary isn't found.Objective
MDS-6179