MDS-3074: Accept shape files for NoW file uploads #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used an issue--fix it
github-actions
bot
added
💻 Frontend
|
Review Reminders
|
exzizt
added
👍 Ready for review
mhuseinov
reviewed
Nov 16, 2020
| @@ -53,7 +53,7 @@ class FileUpload extends React.Component { | |||
| chunkSize: this.props.chunkSize, | |||
| metadata: { | |||
| filename: file.name, | |||
| filetype: file.type, | |||
| filetype: file.type || "application/octet-stream", | |||
There was a problem hiding this comment.
May be "application/octet-stream" can be moved to constants. What do you think?
mhuseinov
previously approved these changes
Nov 16, 2020
exzizt
added
🎫 Ticket closer
🚧 WIP
exzizt
dismissed
mhuseinov’s stale review
Not sure what the heck happened but it's resorted back to not working--so I'll have to take another look. :/
mhuseinov
reviewed
Nov 18, 2020
| @@ -44,7 +44,7 @@ | |||
| "react": "^16.13.1", | |||
| "react-async-script-loader": "^0.3.0", | |||
| "react-dom": "^16.13.1", | |||
| "react-filepond": "^7.0.1", | |||
| "react-filepond": "^7.1.0", | |||
There was a problem hiding this comment.
Have you verified if filepond works correctly after this change? Especially the inspector signature upload?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main
Other
Screenshots
Notes