Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDS-3074: Accept shape files for NoW file uploads #1537

Merged
merged 12 commits into from
Nov 19, 2020

Conversation

exzizt
Copy link
Contributor

@exzizt exzizt commented Nov 16, 2020

Main

  • Users can now upload spatial files to a NoW

Other

  • Fixes an issue where TUSD wouldn't return proper "file type" metadata for obscure file types, such as spatial files
  • Tidies some code

Screenshots

image

Notes

@exzizt exzizt self-assigned this Nov 16, 2020
@github-actions github-actions bot added 💻 Frontend This pull request includes frontend changes. 💾 Backend This pull request includes backend changes. labels Nov 16, 2020
@github-actions
Copy link

Review Reminders

  • Are there auth tests for new endpoints?
  • Are there snapshot tests for new React components?

@exzizt exzizt added 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 💊 Fix Fixes something that isn't working :) labels Nov 16, 2020
@@ -53,7 +53,7 @@ class FileUpload extends React.Component {
chunkSize: this.props.chunkSize,
metadata: {
filename: file.name,
filetype: file.type,
filetype: file.type || "application/octet-stream",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be "application/octet-stream" can be moved to constants. What do you think?

mhuseinov
mhuseinov previously approved these changes Nov 16, 2020
@exzizt exzizt added 🎫 Ticket closer 🚧 WIP This is work in progress code that may change significantly. and removed 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. labels Nov 17, 2020
@exzizt exzizt dismissed mhuseinov’s stale review November 17, 2020 00:00

Not sure what the heck happened but it's resorted back to not working--so I'll have to take another look. :/

@@ -44,7 +44,7 @@
"react": "^16.13.1",
"react-async-script-loader": "^0.3.0",
"react-dom": "^16.13.1",
"react-filepond": "^7.0.1",
"react-filepond": "^7.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified if filepond works correctly after this change? Especially the inspector signature upload?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it works!

@mmumby mmumby closed this Nov 18, 2020
@mmumby mmumby reopened this Nov 18, 2020
@exzizt exzizt closed this Nov 18, 2020
@exzizt exzizt reopened this Nov 18, 2020
Copy link
Contributor

@mhuseinov mhuseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@exzizt exzizt merged commit c5de743 into develop Nov 19, 2020
@exzizt exzizt deleted the MDS-3074-Accept-shape-files-for-NoW-file-upload branch November 19, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💾 Backend This pull request includes backend changes. 💊 Fix Fixes something that isn't working :) 💻 Frontend This pull request includes frontend changes. 🚧 WIP This is work in progress code that may change significantly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants