[MDS-5427] Fix typo & add feature flag (#2630) (#2631)

[MDS-4153] Fix typo & add feature flag (#2630) * fix typo * feature flag on replace documents * fixing mistake, had set replace file flag to off, change back to prod check
bcgov · Aug 16, 2023 · 7e80058 · 7e80058
1 parent 5ca60be
commit 7e80058
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 6 deletions.
diff --git a/services/common/src/utils/featureFlag.ts b/services/common/src/utils/featureFlag.ts
@@ -2,10 +2,12 @@ import { detectProdEnvironment as IN_PROD } from "./environmentUtils";
 
 export enum Feature {
   MAJOR_PROJECT_ARCHIVE_FILE,
+  DOCUMENTS_REPLACE_FILE,
 }
 
 const Flags = {
   [Feature.MAJOR_PROJECT_ARCHIVE_FILE]: !IN_PROD(),
+  [Feature.DOCUMENTS_REPLACE_FILE]: !IN_PROD(),
 };
 
 /**

diff --git a/...es/core-api/app/api/projects/project_summary/resources/project_summary_document_upload.py b/...es/core-api/app/api/projects/project_summary/resources/project_summary_document_upload.py
@@ -26,6 +26,7 @@ def post(self, project_guid, project_summary_guid):
         if not mine:
             raise NotFound('Mine not found')
 
+        # FEATURE FLAG: DOCUMENTS_REPLACE_FILE
         if Config.ENVIRONMENT_NAME != 'prod':
              # TODO: Remove the ENV check and else part when 5273 is ready to go live
             return DocumentManagerService.validateFileNameAndInitializeFileUploadWithDocumentManager(

diff --git a/services/core-web/common/models/documents/document.ts b/services/core-web/common/models/documents/document.ts
@@ -1,4 +1,4 @@
-import { USER_ROLES } from "@mds/common";
+import { USER_ROLES, Feature, isFeatureEnabled } from "@mds/common";
 
 export enum FileOperations {
   View = "Open in document viewer",
@@ -111,7 +111,7 @@ export class MineDocument {
     return [
       this.file_type === ".pdf" && FileOperations.View,
       FileOperations.Download,
-      canModify && FileOperations.Replace,
+      isFeatureEnabled(Feature.DOCUMENTS_REPLACE_FILE) && canModify && FileOperations.Replace,
       canModify && FileOperations.Archive,
       canModify && FileOperations.Delete,
     ];

diff --git a/services/core-web/src/components/noticeOfWork/applications/review/activities/Camps.js b/services/core-web/src/components/noticeOfWork/applications/review/activities/Camps.js
@@ -49,7 +49,7 @@ export const Camps = (props) => {
             validate: props.isPreLaunch ? [number] : [number, required],
           },
           {
-            title: "Number of Sructures",
+            title: "Number of Structures",
             value: "number_structures",
             component: RenderField,
             minRows: 1,

diff --git a/...s/components/noticeOfWork/applications/review/activities/__snapshots__/Camps.spec.js.snap b/...s/components/noticeOfWork/applications/review/activities/__snapshots__/Camps.spec.js.snap
@@ -33,7 +33,7 @@ exports[`Camps renders properly 1`] = `
         Object {
           "component": [Function],
           "minRows": 1,
-          "title": "Number of Sructures",
+          "title": "Number of Structures",
           "validate": Array [
             [Function],
             [Function],

diff --git a/services/minespace-web/common/models/documents/document.ts b/services/minespace-web/common/models/documents/document.ts
@@ -1,4 +1,4 @@
-import { USER_ROLES } from "@mds/common";
+import { USER_ROLES, Feature, isFeatureEnabled } from "@mds/common";
 
 export enum FileOperations {
   View = "Open in document viewer",
@@ -111,7 +111,7 @@ export class MineDocument {
     return [
       this.file_type === ".pdf" && FileOperations.View,
       FileOperations.Download,
-      canModify && FileOperations.Replace,
+      isFeatureEnabled(Feature.DOCUMENTS_REPLACE_FILE) && canModify && FileOperations.Replace,
       canModify && FileOperations.Archive,
       canModify && FileOperations.Delete,
     ];